Compute, rather than read from input, deformation_coef_* fields at model startup#1419
Compute, rather than read from input, deformation_coef_* fields at model startup#1419mgduda wants to merge 2 commits intoMPAS-Dev:developfrom
deformation_coef_* fields at model startup#1419Conversation
…del startup
This commit removes the deformation_coef_{c2,s2,cs,c,s} fields from the
definition of the 'invariant' stream in the atmosphere core's Registry.xml file
(effectively removing them from the 'input' and 'restart' streams as well), and
adds a new routine, atm_initialize_deformation_weights, to the atm_core module
to compute these fields at model start-up.
…sphere core
This commit removes the deformation_coef_{c2,s2,cs,c,s} fields from the
init_atmosphere core, including the removal of these fields from the
init_atmosphere core's Registry.xml file as well as the removal of code
in the atm_advection module for computing these fields.
mgduda
changed the title
deformation_coef_* fields at model startup
|
Note that the code in |
| logical, pointer :: on_a_sphere | ||
| real (kind=RKIND), pointer :: sphere_radius | ||
|
|
||
|
|
There was a problem hiding this comment.
Is the extra newline here required?
There was a problem hiding this comment.
Using two blank lines after local variable declarations is something that we do in other parts of the code. See, e.g., lines 1658 - 1659 in this same file.
There was a problem hiding this comment.
For other examples, see mpas_halo.F and the subroutines therein.
|
I've tested the PR with a real global case and also the LES case - and get bit identical results with the current develop HEAD. Code changes look good - checked the current PR against the develop branch prior to the merge of the LES PR. |
2 participants
This PR modifies both the
init_atmosphereandatmospherecores so that thedeformation_coef_{c2,s2,cs,c,s}fields are computed by the model during its initialization rather than being read from a netCDF input file (either an invariant file, an initial conditions file, or a restart file).The changes in this PR may be logically viewed as occurring in three steps:
atmospherecore to compute thedeformation_coef_{c2,s2,cs,c,s}fields at model start up using identical code to that which is found in theinit_atmospherecoredeformation_coef_{c2,s2,cs,c,s}fields from theatmospherecore's 'invariant' stream (effectively removing these fields from the 'input' and 'restart' streams as well) so the fields are no longer read from netCDF input files.deformation_coef_{c2,s2,cs,c,s}fields and their computation from theinit_atmospherecore.