Skip to content
This repository was archived by the owner on Oct 23, 2020. It is now read-only.

Add support for building MPAS on titan with cray and pgi#259

Merged
mgduda merged 1 commit intoMPAS-Dev:release-v3.0from
douglasjacobsen:all/titan_makefile_changes
Nov 6, 2014
Merged

Add support for building MPAS on titan with cray and pgi#259
mgduda merged 1 commit intoMPAS-Dev:release-v3.0from
douglasjacobsen:all/titan_makefile_changes

Conversation

@douglasjacobsen
Copy link
Copy Markdown
Member

This adds build targets for PGI and Cray compilers on titan.

@douglasjacobsen
Copy link
Copy Markdown
Member Author

This was provided as part of https://github.com/MPAS-Dev/MPAS-Release/pull/14

Comment thread Makefile Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks almost identical to the pgi-nersc target.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this one does look identical. We can probably remove it from the PR.

@mgduda
Copy link
Copy Markdown
Contributor

mgduda commented Nov 5, 2014

I think we may be on the verge of a slippery slope when it comes to build targets; if we can determine that the new targets are in fact compatible with existing targets, it might be preferable to use the new targets as synonyms for the existing targets, and to perhaps generalize the existing targets.

@douglasjacobsen
Copy link
Copy Markdown
Member Author

I know at least the titan-cray build target is not compatible with previous build targets, or at least the modifications are required for titan at a minimum.

I think if the modifications are also compatible with nersc machines, it might be preferable to merge the two together, and just update the modifications, but I don't know if the flags work on nersc machines as well and I'm not sure if there will be time to test this prior to our release.

@douglasjacobsen
Copy link
Copy Markdown
Member Author

I removed the titan-pgi build target. But I'd still like the titan-cray build target for now.

In the future we can look at consolidating these build targets together, but that won't happen prior to v3.0.

@douglasjacobsen douglasjacobsen force-pushed the all/titan_makefile_changes branch from 185c865 to 9f1b947 Compare November 6, 2014 18:14
@mgduda mgduda merged commit 9f1b947 into MPAS-Dev:release-v3.0 Nov 6, 2014
@mgduda mgduda deleted the all/titan_makefile_changes branch November 6, 2014 18:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants