This repository was archived by the owner on Oct 23, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This appears to be a superset of the cray-nersc target, with the exception of the CC_SERIAL variable. Is there any chance that these two targets -- cray-nersc and titan-cray -- are compatible?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other main difference between titan-cray and cray-nersc is the FFLAGS_OPT. Most notable the -s integer32. But this also might be needed on cray-nersc eventually. I think we were building using cray 8.3.0 and 8.3.4 when this came up, but essentially crays compiler defaults to using integer_8 for all integers, which causes the esmf time library to not build because their division interfaces become redundant for integer_4 and integer*8.