Create ismip7_run test group#964
Merged
Merged
Conversation
trhille
marked this pull request as draft
June 9, 2026 19:24
trhille
force-pushed
the
landice/ismip7_run
branch
2 times, most recently
from
June 11, 2026 16:16
0a24291 to
7abdb49
Compare
matthewhoffman
self-requested a review
July 20, 2026 22:24
matthewhoffman
approved these changes
Jul 20, 2026
matthewhoffman
left a comment
matthewhoffman
left a comment
Member
There was a problem hiding this comment.
Approving based on successful setup of initial runs! (to be rebased after ismip7_forcing gets merged)
trhille
marked this pull request as ready for review
July 20, 2026 22:52
Create test group to control both AIS and GIS simulations for ISMIP7.
Remove incorrect mode="forward;analysis" from streams files. This line causes runs to terminate with an error.
Fix case mismatch between smb and SMB, as well as issue that confused SMB with SMB_gradient and temperature with temperature_gradient files.
Symlink to forcing files instead of copying them to run directory. This saves lots of time when running `compass setup` because some forcing files are dozens of GB in size.
Begin historical runs in 2000 instead of 1850 and set proper reference_time for each input field.
Remove lapse rate fields from streams for now, since they do not yet exist in MALI. Once they are added, revert this commit.
Set maximum time step to one month, consistent with forcing intervals.
Begin simulations on Jan 15 instead of Jan 1 to be consistent with time stamps for most forcing. Note that this is not consistent with annual ocean thermal forcing for AIS.
Remove the option to turn face-melting off in the .cfg files. We always want to have face-melting turned on for ISMIP7, and having this option in the .cfg file exposes us to user error unnecessarily.
Add time-averaged flux fields to annual output stream.
For Greenland, we use the depth-integrated solver with Budd friction (hydrostatic N and q=1/3), crevasse-depth calving with a stress multiplier factor of 5, RK2 time integration, and 3rd order FCT.
End simulations on Jan 15 instead of Jan 1 to be consistent with forcing time stamps.
Add --cpu-bind=cores to srun command. Testing doesn't show a noticeable difference when this is added, but this is how we run outside of COMPASS.
Creat a new global and regional stats file every year to reduce cost of I/O. Testing in E3SM runs with active Greenland show a significant slowdown due to I/O when the stats files get too long. 1 year is probably shorter than necessary, but will certainly avoid the I/O bottleneck.
Use Jan 1 start and end dates instead of Jan 15. This is in line with interpreting the Jan 15 time-stamp in ISMIP7 forcing files as representing Jan 1 to 31, rather than Jan 15 to Feb 14.
Use a linear Budd bed, which behaves much more stably in testing than the q=1/3 runs. Also start historical GrIS simulations in 2007 to be consistent with BedMachine geometry. Reduce CFL fraction from 0.8 to 0.5 for added stability.
… MALI" This reverts commit e559f62.
Update docs to include explanation of `reference_surface_path`, used when applying lapse rates.
trhille
force-pushed
the
landice/ismip7_run
branch
from
July 20, 2026 23:04
2679b8d to
e25b09a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This merge adds an
ismip7_runtest group that handles both AIS and GIS simulations for ISMIP7. This is based on the existingismip6_runtest group, with necessary modifications based on the early description of the ISMIP7 protocol in the cheat sheet: https://drive.google.com/file/d/1kI4r09NGj3zEmxzbIZrylO94Skm-tBWi/view.Checklist
api.rst) has any new or modified class, method and/or functions listed