docs(bench): definitive NoEncryptMode A/B results and root-cause explanation (P3d) - #388
Merged
Merged
Conversation
…anation (P3d) 3-rep same-window --pk-ab (tuned vs plain, isolates NoEncryptMode): UPDATE 1.62x, DELETE 1.59x, INSERT 1.31x, READ 1.45x in favour of NoEncryptMode=true. Code audit explains it: Storage has two encryption layers - per-record at-rest (EnableAtRestRecordEncryption, default off) and file-level wrappers (Storage.ReadWrite/PageCache, effectiveNoEncrypt = noEncrypt || noEncryption) gated purely by NoEncryptMode. The default NoEncryptMode=false therefore pays AES work on resolution/point/page-cache reads around the (still engaging) raw contiguous fast paths. Follow-up: measured --pk-ab gate for routing hot reads through the raw range path or no-op'ing the wrapper when at-rest encryption is off.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Samenvatting
Stap 1 (definitieve paired cijfers) + stap 2 (root cause) afgerond.
Stap 1 — 3-rep same-window
--pk-ab(tuned vs plain; alleenNoEncryptModeverschilt)tunedops/splainops/sNoEncryptMode=truelevert een uniforme ~1.3-1.6x op ALLE fases, in hetzelfde venster gemeten.Stap 2 — root cause (code-audit)
Storageheeft twee encryptielagen:EnableAtRestRecordEncryption, default uit), énStorage.ReadWrite.ReadBytes/WriteBytes,PageCache.LoadPageFromDisk,effectiveNoEncrypt = noEncrypt || noEncryption) die puur doorNoEncryptModeworden geschakeldvia
Storage.noEncryption.De default (
NoEncryptMode=false) betaalt daardoor AES-GCM-werk op resolutie-, point- enpage-cache-reads rond de (wel degelijk werkende, raw plaintext) fixed-width fast paths — vandaar
de uniforme vertraging op alle fases.
Vervolg (pas na
--pk-ab-bevestiging per stap)de file-level wrapper een no-op maken wanneer at-rest encryptie uit staat — zonder echte
encryptie te verzwakken wanneer
EnableAtRestRecordEncryptionaan staat.Documentatie bijgewerkt (
docs/benchmarks/default-config-pk.md) + changelog (P3d).