Tractography::Properties::get_step_size() function#1069
Merged
Conversation
This function homologates a number of independent pieces of code that try to deal with the fact that the distance between points along a streamline may not be equivalent to the internal step size of the tractography algorithm, nor may such a fixed step size even exist. It also fixes a bug where running the tckstats command where the step size was not defined (e.g. in the output of tckglobal) would result in an error trying to convert an empty string to a float.
dchristiaens
approved these changes
Jul 24, 2017
Member
dchristiaens
left a comment
dchristiaens
left a comment
There was a problem hiding this comment.
Looks good to me. Nice work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As raised here.
Have identified this duplication of code many times, but never gotten around to functionalising it.