Custom Meret Market

[Zintixx]

Summary by CodeRabbit

• New Features

  • Introduced a new serializer for handling custom shop merchandise data.
  • Added functionality to parse and manage custom shop items from XML.

• Bug Fixes

  • Minor version increment indicating improvements and bug fixes.

• Tests

  • Added a new test method for parsing custom shop data, enhancing testing coverage.

[coderabbitai]

Walkthrough

The pull request introduces a minor version increment in the Maple2.File.Parser.csproj file from 2.1.29 to 2.1.30. It adds a new feature to the ServerTableParser class, enabling the parsing of custom shop merchandise data from an XML source. A new file, ShopMeretCustom.cs, is created to define the structure for the custom shop items, and a corresponding test method is added to ServerTableParserTest to validate this functionality.

Changes

File	Change Summary
Maple2.File.Parser/Maple2.File.Parser.csproj	Updated PackageVersion from 2.1.29 to 2.1.30.
Maple2.File.Parser/ServerTableParser.cs	Added a new method ParseShopMeretCustom for deserializing custom shop merchandise data. Added a private field for a custom serializer.
Maple2.File.Parser/Xml/Table/Server/ShopMeretCustom.cs	Introduced classes ShopMeretCustomRoot and ShopMeretCustom for managing shop item data from XML. Defined multiple properties for shop items.
Maple2.File.Tests/ServerTableParserTest.cs	Added a new test method TestMeretShopCustom to test the parsing of custom shop data.

Possibly related PRs

• Parse Shop Furnishing #34: The changes in this PR also involve an update to the PackageVersion in the Maple2.File.Parser.csproj file, similar to the main PR's version increment from 2.1.29 to 2.1.30.
• Parse Meret Market, Shop UGC #35: This PR includes an update to the PackageVersion in the Maple2.File.Parser.csproj file, changing it from 2.1.27 to 2.1.29, which is relevant as it shows a pattern of version updates in the project files.

Suggested reviewers

• AngeloTadeucci

Poem

🐇 In the land of code, where changes bloom,
A version rises, dispelling gloom.
New shops to parse, with treasures untold,
Each item a story, a joy to behold.
With tests in place, let the features play,
Hooray for the updates, hip-hip-hooray! 🎉

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai generate interesting stats about this repository and render them as a table.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 4d743ad and 8e9bdee.

Files selected for processing (4)

• Maple2.File.Parser/Maple2.File.Parser.csproj (1 hunks)
• Maple2.File.Parser/ServerTableParser.cs (3 hunks)
• Maple2.File.Parser/Xml/Table/Server/ShopMeretCustom.cs (1 hunks)
• Maple2.File.Tests/ServerTableParserTest.cs (1 hunks)

Files skipped from review due to trivial changes (1)

• Maple2.File.Parser/Maple2.File.Parser.csproj

Additional comments not posted (5)

Maple2.File.Parser/Xml/Table/Server/ShopMeretCustom.cs (2)

8-10: LGTM!

The ShopMeretCustomRoot class is properly defined and annotated for XML serialization. The class serves as a container for a list of ShopMeretCustom items.

---

12-41: LGTM!

The ShopMeretCustom class is properly defined with attributes for shop item properties. The attributes are correctly annotated for XML serialization. The use of the custom [M2dArray] attribute for the jobRequire attribute and the additionalQuantity property allows for flexible item definitions and complex item configurations.

Maple2.File.Parser/ServerTableParser.cs (3)

47-47: LGTM!

The new private field shopMeretCustomSerializer is properly declared and follows the existing naming convention.

---

85-85: LGTM!

The shopMeretCustomSerializer field is properly initialized in the constructor, following the pattern used for other similar fields.

---

632-642: LGTM!

The new ParseShopMeretCustom method is implemented correctly and follows the existing patterns and conventions:

• It reads the XML data from the correct file path and sanitizes it.
• It deserializes the data using the shopMeretCustomSerializer and validates the result.
• It yields a tuple of (int Id, ShopMeretCustom ShopMeret) for each item, which is consistent with other parsing methods.

The method adds support for parsing custom shop meret data and integrates well with the existing codebase.