Skip to content

Fix: Parsing Guild Events#57

Merged
AngeloTadeucci merged 3 commits intoMS2Community:masterfrom
Zintixx:fix-guild-event
Mar 6, 2026
Merged

Fix: Parsing Guild Events#57
AngeloTadeucci merged 3 commits intoMS2Community:masterfrom
Zintixx:fix-guild-event

Conversation

@Zintixx
Copy link

@Zintixx Zintixx commented Mar 6, 2026

Summary by CodeRabbit

  • Bug Fixes

    • Corrected the data source used for guild event parsing.
  • Tests

    • Updated a unit test to validate the correct guild parsing flow.
  • Chores

    • Bumped package version to 2.3.8.
    • Adjusted CI checkout to reference the PR head repository for format workflow.

@coderabbitai
Copy link

coderabbitai bot commented Mar 6, 2026

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e03e94b7-0507-45b7-b473-f15144f61958

📥 Commits

Reviewing files that changed from the base of the PR and between e09704d and a125b01.

📒 Files selected for processing (1)
  • .github/workflows/format.yml

📝 Walkthrough

Walkthrough

Version bump to 2.3.8, an XML source path change in ParseGuildEvent, a corresponding test update, and a small workflow checkout change to use the PR head repository.

Changes

Cohort / File(s) Summary
Project Version
Maple2.File.Parser/Maple2.File.Parser.csproj
Incremented NuGet package version from 2.3.7 to 2.3.8.
Parser & Test
Maple2.File.Parser/TableParser.cs, Maple2.File.Tests/TableParserTest.cs
Changed ParseGuildEvent XML source from "table/guildcontribution.xml" to "table/guildevent.xml"; updated test to iterate the appropriate parse method results.
CI Workflow
.github/workflows/format.yml
Added repository input to actions/checkout to use the PR head repository full name.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

🐰 I hopped through code with nimble feet,

bumped a version, swapped an XML sheet.
Tests now chase the proper trail,
CI checks the PR's own mail.
Cheerful changes, small and sweet!

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Fix: Parsing Guild Events' directly relates to the main change: correcting the XML source file used by ParseGuildEvent from 'guildcontribution.xml' to 'guildevent.xml'.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@AngeloTadeucci AngeloTadeucci merged commit f79f10b into MS2Community:master Mar 6, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants