fix: support Bitrise build-number injection in updateBuildVersion.sh - #325
Merged
Merged
Conversation
The semver-only rewrite dropped the ability to stamp CI's own build number onto CURRENT_PROJECT_VERSION (e.g. 5.1.1.0 -> 5.1.1.677). --build now optionally takes an explicit number to set the build component directly, without touching MARKETING_VERSION, so Bitrise can call `updateBuildVersion.sh --build $BITRISE_BUILD_NUMBER`. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
updateBuildVersion.sh(patch/minor/major) dropped the ability to stamp CI's own build number ontoCURRENT_PROJECT_VERSION.--buildnow optionally takes an explicit number (--build 677) to set the 4th component directly (e.g.5.1.1.0 -> 5.1.1.677) without touchingMARKETING_VERSION— for Bitrise usage:updateBuildVersion.sh --build $BITRISE_BUILD_NUMBER.--buildwith no number still auto-increments the build component (existing local-dev behavior), andpatch|minor|majorstill bumpMARKETING_VERSIONas before.Test plan
updateBuildVersion.sh --build 677on a copy ofproject.pbxproj: MARKETING_VERSION unchanged (5.1.1), CURRENT_PROJECT_VERSION 5.1.1.0 -> 5.1.1.677 (10 build configs updated)updateBuildVersion.sh patch --build: MARKETING_VERSION 5.1.1 -> 5.1.2, CURRENT_PROJECT_VERSION 5.1.1.677 -> 5.1.2.678Note: Bitrise's workflow step needs updating to call
updateBuildVersion.sh --build $BITRISE_BUILD_NUMBER(previously used the old-p/-i/-binterface, which no longer exists after the semver rewrite).🤖 Generated with Claude Code