Launcher: add Epic Games Store platform - #228
Conversation
|
Warning Review limit reached
Next review available in: 57 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
WalkthroughAdds Epic Games Launcher manifest discovery and launcher wiring for the ChangesEpic Launcher Integration
Estimated code review effort: 3 (Moderate) | ~25 minutes Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
269f8e7 to
26de343
Compare
|
Woops sorry, didnt mean to close--was cleaning out my branches. |
Resolve the game through the Epic launcher's plaintext manifests: new External::Epic component, ProjectPlatform::EPIC, and RunInnerEpicChecks mirroring the Steam path.
ToLower and FileName are not Epic-specific; drop the anonymous namespace in manifest.cpp and share them from utils/string_utils.h.
c298dbc to
e93686b
Compare
There was a problem hiding this comment.
🧹 Nitpick comments (1)
code/framework/src/utils/string_utils.h (1)
46-58: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winRemove the duplicate helper implementations.
The supplied repository context shows identical
ToLowerandFileNameimplementations incode/framework/src/launcher/project.cppLines 47-58,code/framework/src/launcher/project.hLines 47-58, andcode/framework/src/external/epic/manifest.hLines 47-58. Replace those copies withFramework::Utils::StringUtils::ToLowerandFramework::Utils::StringUtils::FileName. This keeps launcher and Epic matching behavior consistent.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@code/framework/src/utils/string_utils.h` around lines 46 - 58, Remove the duplicate ToLower and FileName helper implementations from the launcher and Epic manifest code, and replace their uses with Framework::Utils::StringUtils::ToLower and Framework::Utils::StringUtils::FileName. Update the relevant code in project.cpp, project.h, and manifest.h while preserving existing matching behavior.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@code/framework/src/utils/string_utils.h`:
- Around line 46-58: Remove the duplicate ToLower and FileName helper
implementations from the launcher and Epic manifest code, and replace their uses
with Framework::Utils::StringUtils::ToLower and
Framework::Utils::StringUtils::FileName. Update the relevant code in
project.cpp, project.h, and manifest.h while preserving existing matching
behavior.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: e0f05989-03d7-45ef-a5c0-5876d321fba1
📒 Files selected for processing (6)
code/framework/CMakeLists.txtcode/framework/src/external/epic/manifest.cppcode/framework/src/external/epic/manifest.hcode/framework/src/launcher/project.cppcode/framework/src/launcher/project.hcode/framework/src/utils/string_utils.h
🚧 Files skipped from review as they are similar to previous changes (5)
- code/framework/CMakeLists.txt
- code/framework/src/launcher/project.cpp
- code/framework/src/launcher/project.h
- code/framework/src/external/epic/manifest.cpp
- code/framework/src/external/epic/manifest.h
Resolve the game through the Epic launcher's plaintext manifests: new External::Epic component, ProjectPlatform::EPIC, and RunInnerEpicChecks mirroring the Steam path.
Summary by CodeRabbit
New Features
Bug Fixes