Fix DP-0 audit recording#20
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ssf auditso DP-0 is counted as recorded when existing state hasdp_0_confirmed: truebut nodp_0_result.dp_0_resultin the state loader sossf state set <change-dir> dp_0_result ...no longer reports success while dropping the field.workflow-startDP-0 instructions and prepare the0.8.11patch release.Root Cause
DP-0 used a different state shape from the other decision points.
workflow-startwrotedp_0_decisions,dp_0_confirmed, anddp_0_timestamp, whilessf auditonly readdp_0_result. The state loader also did not writedp_0_result, so manual CLI updates were lost on writeback.Verification
node --test tests/lib/cmd-audit.test.mjsnode --test tests/lib/state-loader.test.mjsssf audit仍会把 DP-0 误判为 not recorded #18 using a temporary.spec-superflow.yamlnpm run buildnpm testnode scripts/spec-superflow.mjs doctornode scripts/check-version-consistency.mjsFixes #18