polish HTTP 304 docs/test/handling#4129
Merged
khassel merged 3 commits intoMagicMirrorOrg:developfrom Apr 30, 2026
Merged
Conversation
Moves the 304 test from "Basic fetch operations" to the dedicated "HTTP status code handling > 304 Not Modified" block. Also adds an errorSpy to verify that no error event is emitted alongside the response.
Happy path first: readers see the emit-response path before error handling.
khassel
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #4120 was merged, here's a bit of polish on top.
errorSpyto also verify that noerrorevent is emitted.fetch(). This is more intuitive.The bottom line is that this PR improves maintainability. For users, this PR doesn't change anything.