Allow HTTPFetcher to pass through 304 responses

[sonnyb9]

Summary

This updates js/http_fetcher.js so HTTP 304 Not Modified responses are emitted through the normal response event instead of being treated as errors.

That aligns the core fetcher with the built-in yr weather provider in v2.35.0, which already includes explicit logic to handle 304 and reuse cached data.

Closes #4119.

Root cause

HTTPFetcher currently treats all non-OK responses as errors. Since 304 is not an OK response, it never reaches providers listening on the response event.

At the same time, defaultmodules/weather/providers/yr.js expects to receive 304 and handle it by reusing cached data.

What changed

• special-case HTTP 304 in HTTPFetcher
• emit 304 through the normal response event
• preserve the existing error path for other non-OK statuses

Validation

• confirmed defaultmodules/weather/providers/yr.js already expects response.status === 304
• compared the unpatched v2.35.0 HTTPFetcher behavior to the provider logic
• ran node --check js/http_fetcher.js

[rejas]

Please base your PR against the develop branch

[sonnyb9]

Thanks for the reply.

Retargeted this PR to develop and force-pushed a rebased branch so the diff stays limited to the HTTPFetcher change.

I also updated the implementation to treat 304 as part of the successful response path, which preserves the existing serverErrorCount / networkErrorCount reset behavior, and added a focused unit test for that case.

Validation on this checkout: node --check js/http_fetcher.js. I also attempted npm test -- --run tests/unit/functions/http_fetcher_spec.js, but vitest is not installed locally in this environment.

[KristjanESPERANTO]

but vitest is not installed locally in this environment.

Once you run npm run install, you can run the tests.

Is there a reason why the PR is still marked as a draft?

[sonnyb9]

Tests are passing locally now after installing the repo dependencies.

Ran:
./node_modules/.bin/vitest run tests/unit/functions/http_fetcher_spec.js

Result:
Test Files 1 passed (1)
Tests 20 passed (20)

Marked the PR ready for review.

[KristjanESPERANTO]

Looks good, thank! 🙂 Even though there are plenty of clear indications of this, let me ask specifically: This is all Vibe Coded, right?

It’s not a problem for me; I’d just like to have it explicitly stated. Maybe we should include this in our PR requirements, like other projects - specifying how much of the process was handled by AI.

[sonnyb9]

Yes, it was coded with codex/gpt-5.4.