Skip to content

Fixes issue 4243: Ensure while loop in calendar module does not get stuck when no entries - #4244

Open
deBasMan21 wants to merge 1 commit into
MagicMirrorOrg:developfrom
deBasMan21:patch-1
Open

Fixes issue 4243: Ensure while loop in calendar module does not get stuck when no entries#4244
deBasMan21 wants to merge 1 commit into
MagicMirrorOrg:developfrom
deBasMan21:patch-1

Conversation

@deBasMan21

Copy link
Copy Markdown

Fixes: #4243

@KristjanESPERANTO

Copy link
Copy Markdown
Collaborator

Thanks. But please base your pull requests against the develop branch.

@khassel
khassel force-pushed the patch-1 branch 5 times, most recently from abb9177 to 7a4901b Compare September 4, 2026 22:40
@khassel
khassel changed the base branch from master to develop September 4, 2026 22:40
@khassel

khassel commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

@KristjanESPERANTO I was able to switch this to develop

@KristjanESPERANTO

Copy link
Copy Markdown
Collaborator

@deBasMan21 I haven’t looked deeply into this yet, but could moving daysCollected++ outside the if affect how limitDays is intended to work?

@sdetweil

sdetweil commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

Yes, that was why it was counted inside the loop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] All items not loading when calendar loading fails

4 participants