Skip to content

Feature/renovate client#8

Merged
Magolves merged 44 commits into
devfrom
feature/renovate-client
Jan 8, 2026
Merged

Feature/renovate client#8
Magolves merged 44 commits into
devfrom
feature/renovate-client

Conversation

@Magolves

@Magolves Magolves commented Jan 8, 2026

Copy link
Copy Markdown
Owner

Fix broken DoIPClient impl

1. DoIPClient Header (inc/DoIPClient.h)

  • Removed m_tcpClientSocket: Eliminated confusion by using a single m_tcpSocket for TCP connections.
  • Updated Documentation: Clarified comments regarding thread safety and socket management.

2. DoIPClient Implementation (src/DoIPClient.cpp)

  • Fixed connect() Logic: Corrected the return value check for successful connections.
  • Simplified Socket Management: Consolidated TCP socket handling to prevent double-close vulnerabilities.
  • Improved Mutex Coverage: Added mutex protection in sendDiagnosticMessage() to ensure thread safety.
  • Enhanced Error Handling: Improved logging for connection failures and socket operations.
  • Updated Function Signatures: Made startUdpConnection() return a boolean to indicate success or failure.

3. Discover Server and Client Files

  • Renamed Files: Updated file names for consistency and clarity:
    • Discover_Server.cpp to DiscoverServer.cpp
    • DoIP_Uds_Server.cpp to UdsServer.cpp

Magolves and others added 30 commits January 3, 2026 19:20
fix: Potential resource leak when routing act. failed
refactor: Introduce ServerProperties to host VIN, EID
style: Rename some tests
@Magolves
Magolves force-pushed the feature/renovate-client branch from bf0623a to 42e0595 Compare January 8, 2026 17:44
@Magolves
Magolves merged commit 2af5d3f into dev Jan 8, 2026
9 checks passed
@Magolves
Magolves deleted the feature/renovate-client branch January 8, 2026 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant