Feature/renovate client#8
Merged
Merged
Conversation
fix: Potential resource leak when routing act. failed refactor: Introduce ServerProperties to host VIN, EID style: Rename some tests
Magolves
force-pushed
the
feature/renovate-client
branch
from
January 8, 2026 17:44
bf0623a to
42e0595
Compare
chore: Run integration tests only for coverage, but run tests strictly serial
chore: Run integration tests only for coverage, but run tests strictly serial
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix broken DoIPClient impl
1. DoIPClient Header (
inc/DoIPClient.h)m_tcpClientSocket: Eliminated confusion by using a singlem_tcpSocketfor TCP connections.2. DoIPClient Implementation (
src/DoIPClient.cpp)connect()Logic: Corrected the return value check for successful connections.sendDiagnosticMessage()to ensure thread safety.startUdpConnection()return a boolean to indicate success or failure.3. Discover Server and Client Files
Discover_Server.cpptoDiscoverServer.cppDoIP_Uds_Server.cpptoUdsServer.cpp