feat: ship the Hermes Agent mark and give ChatGPT Desktop OpenAI's - #19
Merged
Conversation
Two of the four letter placeholders were avoidable; two were not. Hermes Agent now has a mark. lobe-icons publishes one under the same MIT licence the four existing marks come from, and licenses/lobehub-LICENSE already hashes identical to the copy upstream audited, so no new licence basis is involved. It is byte-identical to lobe-icons' nousresearch.svg but for the <title>, which is right rather than a mix-up: Hermes Agent is Nous Research's product. ChatGPT Desktop rendered "C" while the desktop app has shown OpenAI's mark for it all along -- it is OpenAI's own application sharing Codex's configuration, so the reuse is legitimate. The id-to-file map is now keyed by file rather than assuming id and filename match, which is what lets one file serve two ids without a second copy on disk. Aider and WorkBuddy keep their letters. Neither has a mark in lobe-icons, Aider publishes no brand kit and its Apache-2.0 code licence grants no trademark rights, and WorkBuddy publishes no vector at all. Copying either favicon would ship vendor artwork with no redistribution basis, which asset-rights.json exists to prevent. NOTICE and the component comment now say so rather than leaving the absence unexplained. The dark-scheme e2e allowlist names codex.svg twice, because a file shared by two rows appears once per row. Refs MaimoryLab/BootAgent#133 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Site half of MaimoryLab/BootAgent#133. Upstream shipped the app half in MaimoryLab/BootAgent#134.
Two of the four letter placeholders were avoidable. Two were not, and I did not force them.
Hermes Agent — now has a mark
lobe-icons publishes one under the same MIT licence the four existing marks come from, and
licenses/lobehub-LICENSEalready hashes identical to the copy upstream audited — so no new licence basis is introduced. Byte-identical to the app's copy (02d43c0a…).It is also byte-identical to lobe-icons'
nousresearch.svgbut for the<title>. That is correct rather than a mix-up: Hermes Agent is Nous Research's product, so the company mark identifies it. Recorded in NOTICE so nobody reads the reuse as sloppiness later.ChatGPT Desktop — was showing "C" for no reason
The desktop app has rendered OpenAI's mark for it all along, on the grounds that it is OpenAI's own application sharing Codex's configuration. The site fell back to a letter only because
AgentMark.astroassumed the id and the filename matched.The map is now keyed by file, so one file can serve two ids without a second copy on disk. This was the discrepancy I flagged in #133 — the gap there was site-only.
Aider, WorkBuddy — deliberately still letters
Neither has a mark in lobe-icons. Aider publishes no brand kit, has an open branding issue from 2024, and its Apache-2.0 code licence grants no trademark rights. WorkBuddy publishes no vector at all.
Copying either favicon would ship vendor artwork with no redistribution basis, which is what
asset-rights.jsonexists to prevent. NOTICE and the component comment now state that reasoning, so the next reader does not mistake a decision for an oversight.What the existing guards caught
Both allowlists in this repo did their job, which is worth noting since both are deliberately explicit rather than counted:
src/lib/asset-rights.test.tsenforces bidirectional manifest consistency plus SHA-256. I confirmed it fails on a tampered digest before trusting it.codex.svgtwice — a file shared by two rows appears once per row.Verification
pnpm test— 97 passed (8 files)pnpm run build— 45 pages,validate-build.mjspassedastro check— 0 errors, 0 warningsplaywright test— 181 passed/agents/referenceshermes.svgandcodex.svg, and only Aider and WorkBuddy still render letters🤖 Generated with Claude Code