fix: restore frontend/dist/.keep so a fresh clone builds - #23
Merged
Conversation
d876a7c deleted it, which breaks `go vet ./...` on any clean checkout: manifest_embed.go embeds `all:frontend/dist`, and that pattern has no match when the directory does not exist. main has been red since that push. The file is easy to lose because `vite build` empties dist/, so a `git add -A` afterwards stages the deletion. .gitignore already carries the `!frontend/dist/.keep` exception and a comment explaining this; nothing else is needed beyond putting the file back.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainis red. Run 30967236883 fails atgo vet ./...with:d876a7c(pushed straight tomain, so no PR gated it) deletedfrontend/dist/.keep.manifest_embed.go:18embedsall:frontend/dist, and that pattern has no match when the directory does not exist — so any clean checkout fails to vet, build, or test.Reproduced from a fresh clone before and after:
go vet ./...fails onmain, passes on this branch.Why this keeps happening
Fourth time this file has gone missing.
vite buildemptiesdist/, so agit add -Aafterwards stages the deletion, and the diff line reads as an empty file with no obvious consequence..gitignorealready has the!frontend/dist/.keepexception plus a comment explaining this exact failure, so nothing more is needed beyond putting the file back. No new gate either: CI already catches it, which is howmainwent red. The gap was pushing tomainwithout a PR, not a missing check.Verification
🤖 Generated with Claude Code