fix: verify Windows installer Authenticode publisher - #32
Merged
Conversation
yujiezhang-ops
force-pushed
the
codex/issue-26-macos-install-verification
branch
from
August 5, 2026 04:36
7656371 to
ca5af2d
Compare
yujiezhang-ops
force-pushed
the
codex/issue-27-windows-authenticode
branch
from
August 5, 2026 04:36
a3097d2 to
0d423f2
Compare
yujiezhang-ops
changed the base branch from
codex/issue-26-macos-install-verification
to
main
August 5, 2026 04:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #27
Summary
get.microsoft.com.Get-AuthenticodeSignaturebefore launch.Status == Valid, a signer certificate, and the approvedMicrosoft Corporationpublisher/organization.Tests
python3 -m unittest scripts/test_generate_third_party_licenses.pypython3 scripts/generate_third_party_licenses.py --checkpython3 scripts/check-docs.pygo vet ./...go test ./...GOOS=windows GOARCH=amd64 go test -c ./internal/desktopapp -o /tmp/oneagent-desktopapp-windows.test.execd frontend && pnpm run testcd frontend && pnpm run buildThis PR is intentionally stacked on PR #31 and should be merged after PRs #28, #30, and #31.