Initial support for Arduino core 3.x based on IDF 5 - #837
Merged
Conversation
Author
|
@Makuna this new PR is based on the CORE3 branch and contains your suggestions. |
Makuna
approved these changes
Sep 15, 2024
Makuna
left a comment
Makuna
left a comment
Owner
There was a problem hiding this comment.
Mostly just style issues. My editor can fix those.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
this is a very initial support for for Arduino core 3.x based on IDF 5.
It maintains compatibility with Arduino Core 2 and adds initial support for Arduino core 3.
There is still work to do and some deprecations to fix but we need to start somewhere :)