Off by one in MessageTask queue

[alltheblinkythings]

We pop garbage on the first call to MessageTask::PopMessage, and are always one behind when we pop.

To explain by example:

• a newly created queue has _indexFront=0 and _indexBack=0.
• the first call to MessageTask::SendAsyncMessage writes to offset 1 in the queue buffer (_indexBack + 1).
• the first call to MessageTask::PopMessage reads from _indexFront, which points to offset 0 in the queue buffer.

[Makuna]

#18

If you could pick up this change and confirm it works for you it would be great.
thanks

[awegmann]

Same problem in my project. Would like to use the messaging feature. Please fix the bug.

[Makuna]

@awegmann does my change listed above solve it for you?

[awegmann]

I didn't try the fix, but I have the same issue. First pop of the queue isn't a valid packet. Every subsequent pop delivers one message behind the head of the message queue.

[awegmann]

FYI. I just patched the SendAsyncMessage function as described in issue #18 . Works perfect for me. So it would be perfect if you merge the branch and build a new official version.

[Makuna]

I have been just waiting for a confirmation, thanks

[Makuna]

New release 1.1.5 has been created with the fix.
It may take the Arduino Library Manager a day or two to pick up the new release.