Skip to content

Add segmented sliding-window storage - #65

Merged
Malkovsky merged 3 commits into
mainfrom
experiment/split-span-overhead
Sep 3, 2026
Merged

Add segmented sliding-window storage#65
Malkovsky merged 3 commits into
mainfrom
experiment/split-span-overhead

Conversation

@Malkovsky

Copy link
Copy Markdown
Owner
  • Updated storage API to return array of two spans rather then single span
  • Introduced sliding window storage

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 31, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-02T21:18:36.872207Z c18cf17 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 27d7b3cd1f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread include/pixie/storage.h
Comment on lines +47 to +50
position_type begin_position() const { return impl().begin_position_impl(); }

/** @brief Return the position one past the last logical byte exposed. */
position_type end_position() const { return impl().end_position_impl(); }

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Document the new storage extension-point requirements

Add canonical Doxygen contracts for begin_position_impl(), end_position_impl(), and both segments_impl() variants. The facade now requires these hooks—and serialization depends on them—but only documents the public wrappers, leaving implementers without the required invariants for absolute positions, range validation, segment ordering, and lifetime/invalidation behavior. Concrete-class comments do not replace the CRTP extension-point contract.

AGENTS.md reference: AGENTS.md:L86-L92

Useful? React with 👍 / 👎.

@codecov

codecov Bot commented Aug 31, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.50000% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.96%. Comparing base (2a43cde) to head (c18cf17).

Files with missing lines Patch % Lines
include/pixie/storage.h 93.33% 0 Missing and 2 partials ⚠️
include/pixie/storage/sliding_window.h 95.74% 1 Missing and 1 partial ⚠️
include/pixie/split_span.h 94.44% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #65      +/-   ##
==========================================
+ Coverage   90.66%   90.96%   +0.30%     
==========================================
  Files          47       49       +2     
  Lines       12220    12395     +175     
  Branches     1771     1778       +7     
==========================================
+ Hits        11079    11275     +196     
+ Misses        533      518      -15     
+ Partials      608      602       -6     
Flag Coverage Δ
gcov 90.96% <97.50%> (+0.30%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Malkovsky
Malkovsky merged commit 6f1be75 into main Sep 3, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant