Add States.Format intrinsic function#258
Merged
Merged
Conversation
Fryguy
force-pushed
the
states_format
branch
4 times, most recently
from
417f75c to
ae24fe9
Compare
Member
|
Checked commits Fryguy/floe@747ad87~...7cf8cca with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@kbrock Please review.
Note that I am finding a lot of complications around escaped characters particularly with how the spec describes them and what the stepfunctions tool is doing. So, I've marked these as TODO/pending, and plan to work on them in a follow up. I think that States.Format is too useful to not get in based on these edge cases, so I'd like to merge this now, and work on those afterwards.
Part of #64