Apply rubocop fixes to RoleManagement

[djberg96]

This applies all of the rubocop fixes that can be applied via rubocop -A to the RoleManagement class. It's a mix of formatting tweaks, using alias instead of alias_method, removal of redundant self calls, plus some changes to the way some loops are handled.

Of these, I think the loop change might be the only one we might not want, in which case we should update the cop.

[djberg96]

@jrafanie Look ok?

[jrafanie]

Sorry, for the slow review. I'm mostly good with the changes. A few comments are above.

[Fryguy]

Interesting...I'm curious why this was in the original code at all... .each will effectively be a no-op anyway. Not for this PR, but this line can be removed in a follow-up

[djberg96]

Noted.

[Fryguy]

Of these, I think the loop change might be the only one we might not want, in which case we should update the cop.

which one is the loop change?

[djberg96]

Of these, I think the loop change might be the only one we might not want, in which case we should update the cop.

which one is the loop change?

https://github.com/ManageIQ/manageiq/pull/20881/files#diff-cbd3ec3e096cbe173ed3536046e328fd0350c56f9fcbdd90f14e255d506022c3R159-R165

[Fryguy]

That one seems fine to me...it's a straight syntactical change.

[Fryguy]

@djberg96 Can you squash commits? Otherwise the history shows a delete and a re-add which is confusing.

[Fryguy]

LGTM - just needs a squash.

[djberg96]

@djberg96 Can you squash commits? Otherwise the history shows a delete and a re-add which is confusing.

lol, I just did that, gimme 2 minutes!

....ok done.

[miq-bot]

Checked commit https://github.com/djberg96/manageiq/commit/ef3335109175b35492b09b17dd297c3944f91ec6 with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint
1 file checked, 2 offenses detected

app/models/miq_server/role_management.rb

• ❗ - Line 135, Col 3 - Style/Alias - Use alias instead of alias_method in a module body.
• ❗ - Line 175, Col 3 - Style/Alias - Use alias instead of alias_method in a module body.