Reduce gem size by excluding test files#216
Merged
Merged
Conversation
yuri-zubov
commented
May 23, 2026
|
|
||
| spec.files = `git ls-files -z`.split("\x0") | ||
| spec.executables = spec.files.grep(%r{^bin/}) { |f| File.basename(f) } | ||
| spec.test_files = spec.files.grep(%r{^(test|spec|features)/}) |
Contributor
Author
There was a problem hiding this comment.
The test_files directive is no longer used by RubyGems.org.
kbrock
approved these changes
May 23, 2026
Member
kbrock
left a comment
There was a problem hiding this comment.
We have no tests or exe. It is boilerplate. Assuming we will not have new lines in our file names, so while that change is not necessary, looks good
Member
|
is the gemspec required to be part of the package? I feel like we should include that one too. |
Member
|
EDIT: Oh I see in your actioncable example there they don't have it - that works for me 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the *.gemspec file to optimize the gem package size and structure
whitch files was deleted?
ps: you can see on rails repo