This repository was archived by the owner on Aug 25, 2021. It is now read-only.
[WIP] Fixing keydown for toolbar button#183
Closed
kavyanekkalapu wants to merge 1 commit into
Closed
Conversation
kavyanekkalapu
changed the title
Member
|
Checked commit kavyanekkalapu@be14ea4 with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint |
himdel
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is WIP PR
Trying to fix ManageIQ/manageiq-ui-classic#7360
If i remove keyDown property, Focus is working MIQ toolbars, but it is broken in this demo env. Need to fix that.
CC @skateman @himdel @h-kataria