Add type annotations to table.py - #4641
Merged
Merged
Conversation
# Conflicts: # manim/mobject/table.py
behackl
approved these changes
Aug 6, 2026
behackl
left a comment
Member
There was a problem hiding this comment.
I pushed a reviewer commit reverting these parameters to Iterable. Sequence excludes NumPy arrays at type-checking time, even though arrays are documented and supported table inputs.
The constructor now materializes the outer and inner iterables immediately, so Iterable accurately reflects what the implementation requires while also safely supporting generators. I added regression coverage for iterable data, NumPy label arrays, and empty label iterables.
Happy to merge this now; thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
This PR adds type annotations to
table.py.Reviewer Checklist