Skip to content

Fix OpenGL triangulation errors at ring boundaries - #4819

Merged
behackl merged 1 commit into
ManimCommunity:mainfrom
Theelx:fix-triangulation-ring
Aug 1, 2026
Merged

Fix OpenGL triangulation errors at ring boundaries#4819
behackl merged 1 commit into
ManimCommunity:mainfrom
Theelx:fix-triangulation-ring

Conversation

@Theelx

@Theelx Theelx commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Overview: What does this pull request change?

Motivation and Explanation: Why and how do your changes improve the library?

These changes fix a bug that I encountered with OpenGL rendering for certain scenes. However, the bug did cause rendering to error when its conditions were met, so I figured it should be fixed upstream instead of in a local fork.

Links to added or changed documentation pages

I'm not sure if there are any documentation pages that need to be changed, but I'm open to being corrected!

Further Information and Comments

While the diff for utils/space_ops.py shows 6 lines added, the only real change was changing the bit saying j < ring[-1] to j <= ring[-1]. The rest of the changes in that file are a comment plus formatting.

Reviewer Checklist

  • The PR title is descriptive enough for the changelog, and the PR is labeled correctly
  • If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
  • If applicable: newly added functions and classes are tested

@Theelx
Theelx force-pushed the fix-triangulation-ring branch from ed7e082 to dd115d7 Compare June 22, 2026 18:49

@behackl behackl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find, thanks for the fix! Much appreciated!

@behackl
behackl merged commit fbb3f8c into ManimCommunity:main Aug 1, 2026
15 checks passed
@behackl behackl added the pr:bugfix Bug fix for use in PRs solving a specific issue:bug label Aug 1, 2026
@behackl behackl changed the title Fix triangulation ring off-by-one error Fix OpenGL triangulation errors at ring boundaries Aug 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:bugfix Bug fix for use in PRs solving a specific issue:bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants