fix(svg): ignore point-less shape elements - #4917
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A change to SVG parsing in v0.20.0 caused point-less SVG elements to be retained. On Linux, Pango represents whitespace as empty paths, breaking character-to-glyph mapping in Text and resulting in shifted colors and missing lines in Code. This restores the previous behavior by ignoring point-less elements when converting an SVG to mobjects and adds a regression test.
If this works as intended, the rendered image included in the reference manual for
Codeshould get its syntax highlighting fixed. (Broken, live version: https://docs.manim.community/en/stable/reference/manim.mobject.text.code_mobject.Code.html)