Preserve z-index ordering in animation groups - #4918
Merged
behackl merged 1 commit intoAug 9, 2026
Merged
Conversation
behackl
commented
Aug 8, 2026
behackl
left a comment
behackl
left a comment
Member
Author
There was a problem hiding this comment.
... and now also checked manually. I think this is okay and ready to be reviewed. 👍
behackl
marked this pull request as ready for review
August 8, 2026 10:28
behackl
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4834.
Animation groups recursively collected only their nested animation mobjects when determining the static frame cache boundary. This could leave a higher-z mobject in the static frame while an introduced lower-z mobject was rendered on top of it.
Keep the composition wrapper family in the moving set alongside nested animation families, and add a regression test for
SuccessionwithShowPassingFlash.Tests:
pre-commit run --files manim/scene/scene.py tests/module/scene/test_scene.pypytest -q tests/module/scene/test_scene.py tests/module/animation/test_composition.pypytest -q tests/test_graphical_units/test_geometry.py -k 'negative_z_index_AnimationGroup or negative_z_index_LaggedStart or nested_animation_groups_with_negative_z_index'Opened via Codex using GPT-5.6 Sol.