Skip to content

fix(config): restore renderer class bases on config update - #4958

Merged
behackl merged 1 commit into
ManimCommunity:mainfrom
emerardd:fix/restore-renderer-on-config-update
Aug 24, 2026
Merged

fix(config): restore renderer class bases on config update#4958
behackl merged 1 commit into
ManimCommunity:mainfrom
emerardd:fix/restore-renderer-on-config-update

Conversation

@emerardd

Copy link
Copy Markdown
Contributor

Closes #4952.

Summary

  • Reapply the renderer through its property setter when updating from another ManimConfig.
  • Keep config.renderer synchronized with the class bases managed by ConvertToOpenGL.
  • Add a regression test covering an OpenGL tempconfig context, restoration to Cairo, and subsequent Vector construction.

Validation

  • 4 focused configuration, metaclass, and ghost-vector tests
  • 100 renderer round-trip runtime checks
  • Ruff check and formatting
  • Targeted mypy check for manim/_config/utils.py
  • git diff --check

@behackl behackl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that explains the sometimes failing tests due to some sort of renderer corruption -- resetting the renderer was actually broken. Thanks for fixing this, much appreciated! LGTM.

@behackl
behackl merged commit ced9a52 into ManimCommunity:main Aug 24, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test_ghost_vectors_len_and_types sometimes fails

2 participants