-
Notifications
You must be signed in to change notification settings - Fork 111
Add Patch Inspector implementation with IL viewer and search #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Introduced `PatchInspector` to analyze and manage method patches using Harmony. Includes features for viewing intermediate language (IL) code, searching patches by method/namespace/class, and toggling patch states dynamically. Implemented supporting classes like `ILViewerWindow`, `PatchInfo`, and `PatchMethodInfo` for efficient patch management.
ManlyMarco
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality appears to work well, good work.
Could use a couple of xmldocs wherever useful.
It would be nice if it was more tied into other features like jumping to member in dnspy or adding "check for patches" to context menu in inspector, but that can be done later no need to complicate this PR more.
| } | ||
| else | ||
| { | ||
| ilViewerWindows.Remove(window.Key); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This throws in the foreach because collection is modified.
- Disabled auto opening - Added toggle in main list to switch patch state - Moved IL to seperate class - All windows are now draggable and resizable - Proper scaling - Fixed Typos & Logging - Fix collection modify error
ManlyMarco
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌👀👌👀👌👀 That's some 👌👀👌👀 good stuff 👌👀👌👀
Introduced
PatchInspectorto analyze and manage method patches using Harmony. Includes features for viewing intermediate language (IL) code, searching patches by method/namespace/class, and toggling patch states dynamically.