Skip to content

Inspector - Fix whole window dying if contents crash just right #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 9, 2025
Merged

Inspector - Fix whole window dying if contents crash just right #113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 34 additions & 8 deletions RuntimeUnityEditor.Core/Windows/Inspector/Inspector.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,26 @@ protected override void DrawContents()
}
GUILayout.EndHorizontal();

DrawContentScrollView(currentTab);
try
{
DrawContentScrollView(currentTab);
}
catch (Exception e)
{
// Ignore GUILayout exceptions, usually one-off because of lists changing or scrolling
if (!e.Message.Contains("GUILayout"))
{
RuntimeUnityEditorCore.Logger.Log(LogLevel.Error, e);
RuntimeUnityEditorCore.Logger.Log(LogLevel.Warning | LogLevel.Message, "Unhandled exception when showing current tab, deselecting it!");

var stackEntries = currentTab.InspectorStack.Reverse().ToList();
var i = stackEntries.IndexOf(currentTab.CurrentStackItem);
if (i > 0)
currentTab.CurrentStackItem = stackEntries[i - 1];
else
_currentTab = null; //RemoveTab(currentTab);
}
}
}
GUILayout.EndVertical();
}
Expand Down Expand Up @@ -392,13 +411,20 @@ private void DrawContentScrollView(InspectorTab tab)
{
visibleFieldsQuery = visibleFieldsQuery.Where(x =>
{
var name = x.Name();
if (name != null && name.Contains(SearchString, StringComparison.OrdinalIgnoreCase)) return true;
var typeName = x.TypeName();
if (typeName != null && typeName.Contains(SearchString, StringComparison.OrdinalIgnoreCase)) return true;
var value = x.GetValue();
if (value == null || (value is UnityEngine.Object obj && !obj)) return false;
return value.ToString().Contains(SearchString, StringComparison.OrdinalIgnoreCase);
try
{
var name = x.Name();
if (name != null && name.Contains(SearchString, StringComparison.OrdinalIgnoreCase)) return true;
var typeName = x.TypeName();
if (typeName != null && typeName.Contains(SearchString, StringComparison.OrdinalIgnoreCase)) return true;
var value = x.GetValue();
if (value == null || (value is UnityEngine.Object obj && !obj)) return false;
return value.ToString().Contains(SearchString, StringComparison.OrdinalIgnoreCase);
}
catch
{
return false;
}
});
}
visibleFieldsQuery = visibleFieldsQuery.Where(x =>
Expand Down