Reduce memory allocations where convenient #120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes IMGUI rendering performance by reducing GC allocations through pre-allocated layout option arrays and moving expensive filtering operations to the Update loop instead of OnGUI. The changes improve runtime performance without affecting functionality.
- Pre-allocated GUILayoutOption arrays to avoid per-frame allocations in OnGUI
- Moved Inspector entry filtering from OnGUI (DrawContentScrollView) to Update loop to reduce GC pressure
- Added component GUIContent caching in ObjectTreeViewer to reduce allocations
- Converted foreach loops to for loops in hot paths
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
| RuntimeUnityEditor.Core/Windows/Taskbar.cs | Introduced pre-allocated layout option arrays and moved title generation to Enabled property setter |
| RuntimeUnityEditor.Core/Windows/ObjectTree/RootGameObjectSearcher.cs | Made search member blacklist static readonly and moved filtering logic before LINQ chains |
| RuntimeUnityEditor.Core/Windows/ObjectTree/ObjectTreeViewer.cs | Added component name GUIContent caching and pre-allocated layout option arrays |
| RuntimeUnityEditor.Core/Windows/Inspector/VariableFieldDrawer.cs | Applied EmptyLayoutOptions to various GUILayout calls |
| RuntimeUnityEditor.Core/Windows/Inspector/Inspector.cs | Moved entry filtering from DrawContentScrollView to Update method, reducing OnGUI GC allocations |
| RuntimeUnityEditor.Core/Windows/Inspector/Inspector.InspectorTab.cs | Removed unused imports |
| RuntimeUnityEditor.Core/Utils/IMGUIUtils.cs | Added EmptyLayoutOptions and LayoutOptionsNoExpansion constants |
| RuntimeUnityEditor.Core/Utils/Abstractions/GUILayoutShim.cs | Added XML documentation comments |
| RuntimeUnityEditor.Bepin5/PatchInspector/PatchInspector.cs | Applied EmptyLayoutOptions to GUILayout calls |
| RuntimeUnityEditor.Bepin5/PatchInspector/ILViewerWindow.cs | Applied EmptyLayoutOptions to GUILayout calls |
| RuntimeUnityEditor.Bepin5/LogViewer/LogViewerWindow.cs | Applied EmptyLayoutOptions to GUILayout calls |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.