feat: Improve accuracy of polyline click, and refactor variable naming and eliminate duplicate functions in core module. - #76
Merged
Conversation
- rename ambiguous variable names to meaningful
wf9a5m75
added a commit
that referenced
this pull request
Nov 28, 2025
…g and eliminate duplicate functions in core module. (#76) * wip: adjusing polyline click detection * update: Utils, Spercial * - feat: improve the tapping decision accuracy on polyline - rename ambiguous variable names to meaningful * fix: haversineDistance is missing * fix: ktLint errors * fix: ktLint errors * fix: red lines are not drawn
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improve: the accuracy of polyline click detection especially on the geodesic polyline.
Uses GeographicLib for better calculation.
Screen_recording_20251005_111827.webm
Refactor: Improve variable naming and eliminate duplicate functions in core module
This PR improves code readability and maintainability by refactoring variable names and eliminating duplicate functions in the core module. The changes focus on making the codebase more self-documenting and reducing code duplication.
Changes Made
Eliminated duplicate utility functions and improved naming:
Spherical.computeDistanceBetween()
Benefits
Testing