Skip to content

Conversation

@urasakikeisuke
Copy link
Collaborator

This PR replaces the python-lzf library, which is no longer maintained, with python-neo-lzf.
Closes #48

Signed-off-by: urasakikeisuke <keisuke.urasaki@map4.jp>
@urasakikeisuke urasakikeisuke requested a review from amc-nu October 29, 2025 14:37
@urasakikeisuke urasakikeisuke self-assigned this Oct 29, 2025
@urasakikeisuke urasakikeisuke added rd/chore Updating grunt tasks etc; no production code change rd/minor labels Oct 29, 2025
@github-actions
Copy link

github-actions bot commented Oct 29, 2025

Coverage

Coverage Report
FileStmtsMissCoverMissing
src/pypcd4
   __init__.py20100% 
   _version.py18478%15–19
   pointcloud2.py591280%87–101
   pypcd4.py4244889%24–25, 136, 189, 352–353, 567, 583–605, 620–626, 636–646, 657–697, 707–708, 927–929, 949–950, 1071, 1076, 1079
TOTAL5036487% 

Tests Skipped Failures Errors Time
67 1 💤 0 ❌ 0 🔥 0.835s ⏱️

@github-actions
Copy link

Coverage

Coverage Report
FileStmtsMissCoverMissing
src/pypcd4
   __init__.py20100% 
   _version.py18478%15–19
   pointcloud2.py591280%87–101
   pypcd4.py4244889%24–25, 136, 189, 352–353, 567, 583–605, 620–626, 636–646, 657–697, 707–708, 927–929, 949–950, 1071, 1076, 1079
TOTAL5036487% 

Tests Skipped Failures Errors Time
67 1 💤 0 ❌ 0 🔥 0.857s ⏱️

Copy link

@windsurf-bot windsurf-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 To request another review, post a new comment with "/windsurf-review".

Copy link

@amc-nu amc-nu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@urasakikeisuke urasakikeisuke merged commit d53c5e0 into main Oct 29, 2025
12 checks passed
@urasakikeisuke urasakikeisuke deleted the chore/python-neo-lzf branch October 29, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rd/chore Updating grunt tasks etc; no production code change rd/minor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can you replace python-lzf with python-neo-lzf?

3 participants