Styling - Fixes alpha value for hex colors#6023
Merged
rouault merged 3 commits intoMapServer:masterfrom Apr 1, 2020
Merged
Conversation
Fixes issue MapServer#5882. The issue was introduced by the following commit: MapServer@4fbd7ae This commit changes back to the old behavior so that opacity is only applied if the style have any bindings. A test case to test this has also been added.
Contributor
Author
|
It seems like some SLD tests fail. I will have to investigate those. |
Member
|
Looks like I am the one who introduced that regression. I'll take a look at SLD tests. |
Member
|
I just submitted changes in SLD tests to ravhed:hex-opacity branch, see ravhed#1. |
Fix SLD tests
Contributor
Author
Thanks a lot for your help! I haven't had time to look at the tests myself. |
Member
|
@jbo-ads would this bug also affect branch-7-6 code? Just wondering the impact. |
Member
|
@jmckenna Yes, the bug was present since my first SLD changes. |
Member
|
ok thanks @jbo-ads |
Contributor
|
@jbo-abs I let you issue a backport PR to 7.6 branch |
jmckenna
pushed a commit
that referenced
this pull request
Apr 5, 2020
Member
|
cherry-picked into branch-7-6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #5882. The issue was introduced by the following commit:
4fbd7ae
This commit changes back to the old behavior so that opacity is only
applied if the style have any bindings. A test case to test this
has also been added.