-
Notifications
You must be signed in to change notification settings - Fork 16
Split keyboardInteraction.test.js into three parts, with one describe… #606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Get tests working, I hope
5950f5f to
cab6fcf
Compare
popupTabNavigation.test.js / popupTabNavigation.html tabFeatureNavigation.test.js / tabFeatureNavigation.html reticle.test.js / reticle.html
should be treated like promises, and expect should be treated likewise, per this description: https://jestjs.io/docs/asynchronous#asyncawait Unfortunately featureLinks.test.js still fails, despite the above. So, on the theory that the individual describe blocks are competing in the jest environment, split out the one describe that appears to routinely fail, into a new test file:linkTypes.test.js.
7d4ef1a to
fbecf02
Compare
|
@Malvoz give this branch a try with your css changes, please. It might work... |
|
@prushforth I gave it a try: ResultAfter running the grunt command: after npm test: |
|
Dang! Ok I will see if I can fix that. |
to catch all tasks required for testing, including css minification
|
@Malvoz one test is still flaky but the css minification stuff works a charm. I've merged it into this PR. The problem was that the gh CI action was running 'grunt clean copy rollup', not 'grunt default' so the minification task wasn't being run on gh. Other problems may have been old dependencies not being updated, I have updated to the max at this point. Have to clean the house, will check in later. |
|
What are the packages |
|
When you npm install it tells you it's a "peer" dependency of jest that you have to install manually. I don't know what it is. |
|
I ran it a few times and a number of the tests failed on my end, It also seemed to run a little slower but nothing major (from 85s to 170s, on average). The tests that failed were (over 4 tries);
|
featureLinks.html.
… each.
Draft to see if this fixes problems due to test parallelism.