Compilation with ReleaseWithDebugInfo stucks on Xcode. - #469
Merged
Conversation
We compile automatic jacoians (24 k chars headers) without debug symbols.
pair_wise_iterative_closest_point.cpp stayed in CORE_BASE_SOURCES while pose_graph_loop_closure.cpp (which calls PairWiseICP::compute) moved to CORE_MATH_SOURCES, splitting a symbol and its only definition across two static libs with a link-order dependency in the wrong direction. This broke linking for any executable that pulls in PoseGraphLoopClosure without referencing PairWiseICP directly, e.g. multi_view_tls_registration_step_2. pair_wise_iterative_closest_point.cpp also includes an auto-generated Jacobian header, so it belongs in core_math anyway. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DiH2pr8ruiHu6k7Y2wSXS2
pair_wise_iterative_closest_point.cpp (moved into core_math in the previous commit) calls get_rgd_index_3d(), which lived in hash_utils.cpp under CORE_BASE_SOURCES -- reintroducing the same cross-archive circular dependency, just in the opposite direction (core_math needing a symbol from core/core_no_gui instead of the other way around). Nothing else in CORE_BASE_SOURCES/CORE_GUI_SOURCES calls into core_math, so moving hash_utils.cpp there too makes the dependency one-directional again (core/core_no_gui -> core_math, never the reverse). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DiH2pr8ruiHu6k7Y2wSXS2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We compile automatic jacoians (24 k chars headers) without debug symbols.