Merged
Conversation
Collaborator
|
This pull reqest caused several tests to fail...had to nix it. Good idea but did you try running the tests? |
Collaborator
|
I was able to fix the failures by updating the signatures of the ClassAdapter AdaptInvoker signatures to be long,int instead of int,int. Please verify the unit tests going forward, but I agree it's a good update. |
Collaborator
Author
|
Hi, sorry, I just ignore notification without realize you have comments. I'm so sorry about bug from my PR. For all unit tests, I will do it soon. |
Collaborator
|
No problem...thanks for the contributions! |
chaowlert
added a commit
that referenced
this pull request
Sep 28, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Based on your library, you use
intas key of record of {TSource + TDestination + has destination flag}.Even it is very small chance, but it is possible to have key collision when there are a lot of type mappings.
My solution is using
long, TSource will use high-order number, TDestination will use low-order number, and destination flag will be positive and negative.Please review