fix: IgnoreNullValues regression from MapToTarget cases in #905#908
Merged
DocSvartz merged 4 commits intoMapsterMapper:developmentfrom Apr 1, 2026
Merged
fix: IgnoreNullValues regression from MapToTarget cases in #905#908DocSvartz merged 4 commits intoMapsterMapper:developmentfrom
DocSvartz merged 4 commits intoMapsterMapper:developmentfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#858 Bug overview:
Nullable custom ValueType not mapping to custom ValueType
or NotNullable custom ValueType on a potentially nullable path:
property<Class>.property<ValueType>Causes of occurrence:
If custom ValueType on a potentially nullable path:
property<Class>.property<ValueType>ApplyNullPropagation tranform it to(Nullable<ValueType>) property<Class>.property<ValueType>What is actually required only in the case of MapToTarget is to support IgnoreNullValues feature
Since an initially NotNullable source becomes nullable and can be skipped when the value is null
before ApplyNullPropagation
Expression (property<Class>.property<ValueType>) return ValueType data - not nullafter ApplyNullPropagation
Expression ((Nullable<ValueType>) property<Class>.property<ValueType>) return Nullable<ValueType> data - can be null