MDBF-1142 Master migration refactoring #873
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RazvanLiviuVarzaru
force-pushed
the
master-improvements
branch
from
668ca27 to
871f4a6
Compare
RazvanLiviuVarzaru
force-pushed
the
master-improvements
branch
4 times, most recently
from
ecc621e to
cfce52a
Compare
Define workers for: - MDBF-1141 : hz-bbw6 - MDBF-143 : bg-bbw5-x64 - QUAPE sponsored machine: sg-bbw1
The builder can fail before any artifact for saving is produced or simply the builder has nothing to save
Worker selection (canStartBuild) and queue prioritization by branch (nextBuild) should not concern the user. These are considered internal mechanisms, and allowing users to modify them when configuring a builder could lead to unexpected behavior in the master.
RazvanLiviuVarzaru
force-pushed
the
master-improvements
branch
from
cfce52a to
36edfed
Compare
fauust
approved these changes
Nov 12, 2025
Collaborator
fauust
left a comment
fauust
left a comment
There was a problem hiding this comment.
Looks good.
You should probably consider doing some formatting commit only. It would be easier to review next time ;)
| echo "Warning: package '$package' does not exist and will be skipped." | ||
| continue | ||
| fi | ||
| cp -r $package {self.destination} |
Collaborator
There was a problem hiding this comment.
Don't we wont verbose output here cp -vr ? Just a question, maybe a bad idea.
Collaborator
Author
There was a problem hiding this comment.
There's not much interest in a verbose output for this step
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to gather all improvements from:
DockerLatentworkloads #871So the mentioned patches can focus only on feature integration.
Please follow each commit message for more details.