MDEV-25670 Run `mysql_upgrade` / `mariadb-upgrade` at startup

[jjlin]

I was looking into upgrading my instance of MariaDB from 10.4 to 10.5, and according to https://mariadb.com/kb/en/upgrading-from-mariadb-104-to-mariadb-105/, I'm supposed to run mysql_upgrade or mariadb-upgrade as part of the upgrade procedure.

I didn't see this being done anywhere in docker-entrypoint.sh, so I ran it myself after restarting with the mariadb:10.5 image. According to the mysql_upgrade docs:

It's also safe to run mysql_upgrade for minor upgrades, as if there are no incompatibles [sic] between versions it changes nothing.

So it seems like it might be a good idea to just always run it as part of startup to make version upgrades more seamless.

[wglambert]

Duplicate of docker-library/mysql#130 (comment)

[tianon]

I'm not totally sure this is -- I think this is somewhere we could use a little guidance from @grooverdan on whether this is something recent versions of MariaDB do automatically like MySQL 8+ has started doing? 😇 🙏

[grooverdan]

Yep, I agree. Its a good thing to do. Even on minor upgrade there are things it corrects (JSON plugins from 5.7 data directories, mysql.user correctness to name two things I recently remember).

[tianon]

I think the most difficult problem is detection of when it ought to be run because it requires the server to be up before it can run (so it requires the same temporary server logic as the initial bootstrapping), so it isn't reasonable to just run it every time (unless MariaDB's version has an offline mode? 😇)

[grooverdan]

Created https://jira.mariadb.org/browse/MDEV-25670 , might be possible without mysql_upgrade changes.

[julienfritsch44]

@timofeyturenko can you please have a look?

[Thomas131]

This issue created a downtime for me today (move :latest-tag from 10.5 -> 10.6).

[grooverdan]

@Thomas131 can you share your logs of the 10.6 startup. If that' not obvious on the downtime case can you explain it more. Did running mariadb-upgrade/mysql_upgrade in the container resolve it?