Skip to content

Conversation

@tanji
Copy link

@tanji tanji commented Oct 22, 2015

Updated enable_encryption.preset so it contains necessary directives to be fully functional.
Added plugin load and directions to the encryption key.
Added relevant comments and references to the documentation.

Guillaume Lefranc added 2 commits October 22, 2015 14:43
Updated enable_encryption.preset so it contains necessary directives to be fully functional.
Added relevant comments and references to the documentation.
Removed the IV bits which are not needed anymore, and referenced the key format in the comments
@svoj svoj changed the title enable_encryption Preset is not fully functional MDEV-8990 - enable_encryption Preset is not fully functional Oct 22, 2015
@svoj
Copy link
Contributor

svoj commented Oct 22, 2015

Hi Guillaume,

thanks for you contribution. JIRA task has been created to track this pull request: https://mariadb.atlassian.net/browse/MDEV-8990

This task was added to 10.1.9 backlog, which is planned to be handled between 2015-10-27 and 2015-11-17.

Thanks,
Sergey

@vuvova
Copy link
Member

vuvova commented Oct 29, 2015

You misunderstood what this preset file is for. It is not an example configuration that a user should tweak and use. Nor it shows recommended encryption settings. It's a preset that enables gap-less encryption of all data on disk. Like an option --enable-encryption-of-everything. We will extend this file in future releases and want it to be replaced on upgrades — something one should never do with user-edited files.

I will try to clarify this in a file comment.

@vuvova vuvova closed this Oct 29, 2015
ankitkumar031 pushed a commit to ankitkumar031/server that referenced this pull request Apr 16, 2017
…w jobs (MariaDB#110)

This is a change to support both old style and new style until the old style is deprecated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants