Skip to content

Conversation

@janlindstrom
Copy link
Contributor

…error: [ERROR] WSREP: FSM: no such a transition REPLICATING -> COMMITTED

  • The Jira issue number for this PR is: MDEV-33850

Description

Problem was that transacton was BF-aborted after certification succeeded and transaction tried to rollback and during rollback binlog stmt cache containing sequence value reservations was written into binlog.

Transaction must replay because certification succeeded but transaction must not be written into binlog yet, it will be done during commit after the replay.

Fix is to skip binlog write if transaction must replay and in replay we need to reset binlog stmt cache.

Release Notes

TODO: What should the release notes say about this change?
Include any changed system variables, status variables or behaviour. Optionally list any https://mariadb.com/kb/ pages that need changing.

How can this PR be tested?

TODO: modify the automated test suite to verify that the PR causes MariaDB to behave as intended.
Consult the documentation on "Writing good test cases".

If the changes are not amenable to automated testing, please explain why not and carefully describe how to test manually.

Basing the PR against the correct MariaDB version

  • This is a new feature or a refactoring, and the PR is based against the main branch.
  • [ x] This is a bug fix, and the PR is based against the earliest maintained branch in which the bug can be reproduced.

PR quality check

  • [ x] I checked the CODING_STANDARDS.md file and my PR conforms to this where appropriate.
  • [ x] For any trivial modifications to the PR, I am ok with the reviewer making the changes themselves.

…error: [ERROR] WSREP: FSM: no such a transition REPLICATING -> COMMITTED

Problem was that transacton was BF-aborted after certification
succeeded and transaction tried to rollback and during
rollback binlog stmt cache containing sequence value reservations
was written into binlog.

Transaction must replay because certification succeeded but
transaction must not be written into binlog yet, it will
be done during commit after the replay.

Fix is to skip binlog write if transaction must replay and
in replay we need to reset binlog stmt cache.
@janlindstrom janlindstrom added the Codership Codership Galera label Mar 17, 2025
@sysprg
Copy link
Contributor

sysprg commented Apr 2, 2025

Thanks, the fix has been merged with the head revision: 25737db

@sysprg sysprg closed this Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Codership Codership Galera

Development

Successfully merging this pull request may close these issues.

2 participants