Skip to content
/ server Public

MDEV-38008 - main.grant_kill fails sporadically#4414

Merged
svoj merged 1 commit intoMariaDB:10.11from
svoj:pr-10.11-MDEV-38008
Nov 6, 2025
Merged

MDEV-38008 - main.grant_kill fails sporadically#4414
svoj merged 1 commit intoMariaDB:10.11from
svoj:pr-10.11-MDEV-38008

Conversation

@svoj
Copy link
Contributor

@svoj svoj commented Nov 2, 2025

Test output was affected by incompletely closed preceding connections.

Make test agnostic to concurrent connections by querying information_schema.processlist only for connections that it uses.

With bead24b all 3 processlist queries were affected. Before bead24b - only the first one.

@svoj svoj requested a review from Copilot November 2, 2025 15:52
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the grant_kill.test file to make the test more deterministic and focused by filtering the processlist queries to show only relevant connections instead of all system processes.

Key changes:

  • Introduced $default_id variable to capture the default connection ID at the start of the test
  • Replaced INFORMATION_SCHEMA.PROCESSLIST subquery with connection_id() function for getting current connection IDs
  • Added WHERE clause filters to SELECT queries on processlist to limit results to only the test-related connections
  • Removed --source include/wait_until_count_sessions.inc calls that are no longer needed with the more focused approach

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
mysql-test/main/grant_kill.test Refactored test to use connection IDs and filter processlist queries to only relevant connections
mysql-test/main/grant_kill.result Updated expected results to match the new filtered processlist queries

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@svoj svoj added the MariaDB Foundation Pull requests created by MariaDB Foundation label Nov 2, 2025
@svoj svoj force-pushed the pr-10.11-MDEV-38008 branch from 39fc378 to 3056e9d Compare November 2, 2025 15:59
@svoj svoj requested a review from Copilot November 2, 2025 16:00
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@vuvova vuvova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, although it's kind of an overkill. Would be enough to have WHERE id = $id

@svoj
Copy link
Contributor Author

svoj commented Nov 6, 2025

okay, although it's kind of an overkill. Would be enough to have WHERE id = $id

@vuvova sure, strictly speaking this select is not needed at all. I just wanted to keep the fix less intrusive. I will update it as you suggested.

Test output was affected by incompletely closed preceding connections.

Make test agnostic to concurrent connections by querying
information_schema.processlist only for connections that it uses.

With bead24b all 3 processlist queries were affected.
Before bead24b - only the first one.
@svoj svoj force-pushed the pr-10.11-MDEV-38008 branch from 3056e9d to cf8bb0f Compare November 6, 2025 20:28
@svoj svoj merged commit 911e68c into MariaDB:10.11 Nov 6, 2025
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

MariaDB Foundation Pull requests created by MariaDB Foundation

Development

Successfully merging this pull request may close these issues.

3 participants