MDEV-38180: Added XXH3 and XXH32 (64 bit) sql functions#4500
MDEV-38180: Added XXH3 and XXH32 (64 bit) sql functions#4500AbhinavMishra32 wants to merge 1 commit intoMariaDB:mainfrom
Conversation
|
@FooBarrior @mariadb-YuchenPei please review🙂 |
gkodinov
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
This is a preliminary review.
Please consider filling up a complete specification of the function into the related jira. E.g.: How does it calculate the hash for various data types, how does collation matter for strings, type and number of arguments, nullability, expected data type etc.
Please also find one additional optional arguments suggestion below.
e781223 to
d366d55
Compare
d366d55 to
bd1e74a
Compare
gkodinov
left a comment
There was a problem hiding this comment.
It looks like a wrong commit went in here.
Can we just please have the single commit?
And also some better description of the functions added?
|
@mariadb-YuchenPei tells me that since MDEV-9826 has been merged to main, this needs a full rebased onto main, which I've now done. |
Description
Adds native SQL functions
XXH32()andXXH3()exposing xxHash algorithms.Release Notes
Added XXH32() and XXH3() SQL functions that return 32‑bit and 64‑bit xxHash digests (unsigned integers). NULL or empty input returns SQL NULL.
How can this PR be tested?
./mysql-test/mtr main.func_xxh
If the changes are not amenable to automated testing, please explain why not and carefully describe how to test manually.
Basing the PR against the correct MariaDB version
mainbranch.PR quality check