Skip to content
/ server Public

MDEV-38537 - sysschema.pr_ps_setup_show_enabled fails sporadically #4530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
svoj merged 1 commit into from
Jan 12, 2026
Merged

MDEV-38537 - sysschema.pr_ps_setup_show_enabled fails sporadically #4530

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion mysql-test/suite/sysschema/r/pr_ps_setup_show_enabled.result
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ UPDATE performance_schema.threads
SET INSTRUMENTED = 'NO'
WHERE NAME LIKE 'thread/innodb/srv\_%'
OR NAME LIKE '%con\_%'
OR NAME LIKE '%signal_handler%';
OR NAME LIKE '%signal_handler%'
OR (NAME='thread/sql/one_connection' AND PROCESSLIST_ID!=CONNECTION_ID());
CALL sys.ps_setup_show_enabled(FALSE, FALSE);
performance_schema_enabled
1
Expand Down
3 changes: 2 additions & 1 deletion mysql-test/suite/sysschema/t/pr_ps_setup_show_enabled.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@ UPDATE performance_schema.threads
SET INSTRUMENTED = 'NO'
WHERE NAME LIKE 'thread/innodb/srv\_%'
OR NAME LIKE '%con\_%'
OR NAME LIKE '%signal_handler%';
OR NAME LIKE '%signal_handler%'
OR (NAME='thread/sql/one_connection' AND PROCESSLIST_ID!=CONNECTION_ID());
Copy link
Member

@vuvova vuvova Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect that a condition on NAME is redundant, it'd be enough to check PROCESSLIST_ID only.

But ok, shouldn't hurt.

Copy link
Contributor Author

@svoj svoj Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vuvova, result file records the following threads:

enabled_threads thread_type
aria/checkpoint_background      BACKGROUND
innodb/page_cleaner_thread      BACKGROUND
mysys/statement_timer   BACKGROUND
root@localhost  FOREGROUND
sql/main        BACKGROUND
sql/manager     BACKGROUND

I think we want to add to the disable list only foreground threads.


# Show limited info (no thread or instrument info)
CALL sys.ps_setup_show_enabled(FALSE, FALSE);
Expand Down