MDEV-39082 mysql-test: use temp datadir in collect_mysqld_features#4813
Merged
vuvova merged 1 commit intoMariaDB:10.6from Mar 17, 2026
Merged
MDEV-39082 mysql-test: use temp datadir in collect_mysqld_features#4813vuvova merged 1 commit intoMariaDB:10.6from
vuvova merged 1 commit intoMariaDB:10.6from
Conversation
grooverdan
approved these changes
Mar 16, 2026
Member
grooverdan
left a comment
grooverdan
left a comment
There was a problem hiding this comment.
Good. Now if there's feature discovery it will get the lower-case filesystem variables correctly too.
Contributor
Author
nice, glad this keeps the behavior intact. |
gkodinov
added
the
External Contribution
gkodinov
approved these changes
Mar 16, 2026
Member
gkodinov
left a comment
gkodinov
left a comment
There was a problem hiding this comment.
Thank you for your contribution! This is a preliminary review.
LGTM. Please stand by for the final review.
gkodinov
force-pushed
the
mdev-39082-mtr-tempdatadir
branch
from
8303836 to
7342764
Compare
Member
|
eh, sorry, why not to use simply vardir? |
gkodinov
requested changes
Mar 16, 2026
aquilamacedo
force-pushed
the
mdev-39082-mtr-tempdatadir
branch
from
7342764 to
91379d9
Compare
gkodinov
force-pushed
the
mdev-39082-mtr-tempdatadir
branch
from
91379d9 to
139bdbf
Compare
collect_mysqld_features probes mariadbd with --datadir=., which can point to the installed mysql-test tree. During this probe, mariadbd may run the datadir case-sensitivity check and try to create a *.lower-test file there. This is a bad fit when the test suite is run from a read-only installed path (e.g. /usr/share/...). Use $opt_vardir as the datadir for this probe instead, so it runs in a writable location and avoids writes into the installed test tree.
vuvova
force-pushed
the
mdev-39082-mtr-tempdatadir
branch
from
139bdbf to
42ff88b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
collect_mysqld_featuresprobes mariadbd with--datadir=., which canpoint to the installed mysql-test tree.
During this probe, mariadbd may run the datadir case-sensitivity check
and try to create a
*.lower-testfile there. This is a bad fit when thetest suite is run from a read-only installed path (for instance, .
/usr/share/...).Use
$opt_vardiras the datadir for this probe instead, so it runs in awritable location and avoids writes into the installed test tree.