MDEV-39109 main.sp-error stack overflow debug, MSAN and ASAN#4821
Merged
grooverdan merged 1 commit intoMariaDB:10.11from Mar 19, 2026
Merged
MDEV-39109 main.sp-error stack overflow debug, MSAN and ASAN#4821grooverdan merged 1 commit intoMariaDB:10.11from
grooverdan merged 1 commit intoMariaDB:10.11from
Conversation
grooverdan
added
the
MariaDB Foundation
ParadoxV5
reviewed
Mar 19, 2026
MSAN seems error on stack depth 39 so set limit to 20. ASAN error-ed on stack depth 248 so set limit to 200. The actua;ly depth wasn't important for the purposes of the fatal error handling in MySQL bug #15192 from which this test originates. Reviewed/Approved by: Oleksandr "Sanja" Byelkin (sanja@mariadb.com)
Member
Author
|
Thanks @sanja-byelkin for the review! |
kjarir
added a commit
to kjarir/server
that referenced
this pull request
May 4, 2026
The test was expecting only ER_STACK_OVERRUN_NEED_MORE (1436) but under sanitizer builds (UBSAN, MSAN+Debug) the recursive stored procedure call bug10100p(255) fails with ER_SP_RECURSION_LIMIT or succeeds (0) instead, because sanitizer instrumentation increases per-frame stack usage, altering the recursion depth at which the stack guard or recursion limit is hit. Fix: Accept 0 and ER_SP_RECURSION_LIMIT as additional valid outcomes in the test, following the pattern from PR MariaDB#4821. Reviewed-by: <add reviewer>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MSAN seems error on stack depth 39 so set limit to 20.
ASAN errored on stack depth 248 so set limit to 200.
The actualy depth wasn't important for the purposes of the fatal error handling in MySQL bug #15192
from which this test originates.