MDEV-39241: THD::backup_commit_lock warning dangling-pointer#4891
Open
grooverdan wants to merge 1 commit into
Open
MDEV-39241: THD::backup_commit_lock warning dangling-pointer#4891grooverdan wants to merge 1 commit into
grooverdan wants to merge 1 commit into
Conversation
grooverdan
added
the
MariaDB Foundation
The mechanisms of XA backup locks use a stack allocated mdl_request object. This is passed and stored in the THD object. Compilers complain about this behaviour because the lifetime of the THD->backup_commit_lock may exceed the lifetime of the stack variable mdl_request. As the complier is also free to reuse the memory of mdl_request after its last reference in the code, the lifetime of the variable isn't defined after the function call to trans_xa_get_backup_lock. As the THD has an allocation mechanism defined, and can release used memory, lets change this implementation and be explicit, and not rely on the compiler doing the right thing in the realm of undefined behaviour. Caused by MDEV-35110 / 066f920.
svoj
requested changes
May 7, 2026
Contributor
svoj
left a comment
svoj
left a comment
There was a problem hiding this comment.
It is very wrong that the code stores MDL_request in general, it should store MDL_ticket instead. Could you check if it is doable to make this change?
Contributor
|
Dear gents, MDEV-36025 patch and analysis visited this piece of code that the Jira ticket compiler complained. If we carefully check
That is I did not not overlook anything? |
Contributor
|
@andrelkin you're right, it must be compiler bug. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mechanisms of XA backup locks use a stack allocated mdl_request object. This is passed and stored in the THD object. Compilers complain about this behaviour because the lifetime of the THD->backup_commit_lock may exceed the lifetime of the stack variable mdl_request.
As the complier is also free to reuse the memory of mdl_request after its last reference in the code, the lifetime of the variable isn't defined after the function call to trans_xa_get_backup_lock.
As the THD has an allocation mechanism defined, and can release used memory, lets change this implementation and be explicit, and not rely on the compiler doing the right thing in the realm of undefined behaviour.
caused by MDEV-35110 / 066f920